From: Ray Strode Date: Fri, 15 Dec 2017 15:05:34 +0000 (-0500) Subject: background: don't leak wall clock when background changes X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~994^2^2~129 X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=94b96f8d9771d776eca28da72904bb04989238d2;p=gnome-shell.git background: don't leak wall clock when background changes The background code allocates a GnomeWallClock when its first created, but neglects to drop a reference to that clock at destroy time. The undestroyed clocks lead to a timerfd leak that eventually prevents the shell from functioning. https://bugzilla.gnome.org/show_bug.cgi?id=791655 --- diff --git a/js/ui/background.js b/js/ui/background.js index 1c2b83bae..3ea7900e7 100644 --- a/js/ui/background.js +++ b/js/ui/background.js @@ -289,6 +289,8 @@ var Background = new Lang.Class({ this._clock.disconnect(this._timezoneChangedId); this._timezoneChangedId = 0; + this._clock = null; + if (this._prepareForSleepId != 0) LoginManager.getLoginManager().disconnect(this._prepareForSleepId); this._prepareForSleepId = 0;